Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on every word with only one replacement #4

Open
cfreeley opened this issue Mar 7, 2017 · 4 comments
Open

Error on every word with only one replacement #4

cfreeley opened this issue Mar 7, 2017 · 4 comments

Comments

@cfreeley
Copy link

cfreeley commented Mar 7, 2017

In your index.json, many words have a string value for replace instead of an array. Each one of these words gives me an error when you call .join on the replacement here: https://github.com/admhlt/retext-usage/blob/master/index.js#L62

giving: TypeError: quotation(...).join is not a function.

Could you either rework this condition so it only calls join on an array, or wrap every replace in an array, even if it's just one?

@grugnog
Copy link

grugnog commented Mar 19, 2017

Getting this error also

@optimistiks
Copy link

Got this error as well

kostasx added a commit to kostasx/retext-usage that referenced this issue Jan 2, 2018
[Fixing TypeError: quotation(...).join is not a function. ](adamhollett#4)
@kostasx
Copy link

kostasx commented Jan 2, 2018

Forked the repo and made a fix. @adamhollett let me know if I should PR.

@adamhollett
Copy link
Owner

@kostasx Feel free to PR, I'd appreciate that. To be honest I don't use retext much any more so this package hasn't had much attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants