fix: using addContext inside a before or after hook should work as expected
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context to the hook This worked as expected in versions of mocha prior to `6.0.0` but due to a change the assumptions made inside `addContext` no longer held true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to mocha
6.0.0, callingaddContextin abeforeorafterhook would correctly add the context to the hook object. However due to a change in mocha, the assumptions made insideaddContextno longer held true. This is causing the context to be added to the tests instead of the hook. This PR fixes the behavior.Alternate approach to #285. Uses a simple regex to determine if the hook is an
eachhook or not.