3.0 #214
Merged
3.0 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused arrays of collective tests * only use uuids in suite collective test arrays * remove derivable suite properties
* map over suites to clean them; removing empty suites * remove unused removeAllPropsFromObjExcept method * fix/update tests
* Remove unused option * Remove deprecated enableTestCode option * Simplify options handling Only handle options that pertain to the reporter and pass through all others as is. No longer rely on marge for base config. * Update tests
* Update documentation for 3.0
* Update deps * eslint: reorder rules * eslint: update dep; fix lint * Use local lib for functional tests
wking
added a commit
to wking/tap-mocha-reporter
that referenced
this pull request
Jun 7, 2018
Catching up with: * Mocha, which has had these as part of its suites since mochajs/mocha@c0bb9188 (plugging in Hook, 2011-11-25), and * Mochawesome, which has expected arrays since at least adamgruber/mochawesome@5a49d410 (3.0, 2017-11-30, adamgruber/mochawesome#214). Without this change, Mochawesome's: [].concat(suite._beforeAll, suite._beforeEach) will lead to: [undefined, undefined] and Mochawesome will call cleanTest on those undefined values and crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.