-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getCurrentlyPlayingTrack returns string if nothing is currently playing. #22
Labels
Comments
patrick-motard
added a commit
to patrick-motard/spotify-web-api-ts
that referenced
this issue
Feb 7, 2021
`getCurrentlyPlayingTrack` returns an empty string if no song is currently playing. The type response of that function is incorrect, leading to complile errors. This PR fixes the issue by correcting the type response. Fixes adamgrieger#22
patrick-motard
added a commit
to patrick-motard/spotify-web-api-ts
that referenced
this issue
Feb 10, 2021
`getCurrentlyPlayingTrack` returns an empty string if no song is currently playing. The type response of that function is incorrect, leading to complile errors. This PR fixes the issue by correcting the type response. Fixes adamgrieger#22
adamgrieger
pushed a commit
that referenced
this issue
Feb 11, 2021
`getCurrentlyPlayingTrack` returns an empty string if no song is currently playing. The type response of that function is incorrect, leading to complile errors. This PR fixes the issue by correcting the type response. Fixes #22
🎉 This issue has been resolved in version 1.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
thomas-negrault
pushed a commit
to thomas-negrault/spotify-web-api-ts
that referenced
this issue
Apr 10, 2022
`getCurrentlyPlayingTrack` returns an empty string if no song is currently playing. The type response of that function is incorrect, leading to complile errors. This PR fixes the issue by correcting the type response. Fixes adamgrieger#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Editor gives the following warning:
Code works at runtime because the function is returning a string when nothing is playing. I think it should return undefined, or an error, or a status code, to indicate that nothing is playing, and it should indicate that return type in the signature so that typescript doesn't freak out.
The text was updated successfully, but these errors were encountered: