Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker-compose and alpine based Dockerfile #282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

niwo
Copy link

@niwo niwo commented Mar 29, 2019

Adding docker-compose and alpine based image which separates the app from the database

@linuxbandit
Copy link

Looks great! thanks for this. I was going to do the same then I realised someone may have already, thankfully there was you.

Only feedback: I would avoid being root (on line 9 of the Dockerfile)

@J0WI
Copy link

J0WI commented Dec 22, 2019

The *-dev dependencies can be removed afterwards.
Adding libc6-compat is an anti pattern on Alpine Linux. Binaries should be build with musl-libc.
An example can be found here: https://github.com/docker-library/redmine/blob/master/Dockerfile-alpine.template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants