Improve detection of first party apps. #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django apps sometimes are referenced with their dotted path in `settings.FIRST_PARTY_APPS`, e.g. `myproject.myapp`. But the label of the app config is the right most part of the path, e.g. `myapp` which is not in `settings.FIRST_PARTY_APPS` and thus the app will not be considered a first party app. We can improve this by looking at the name of the app config, which should normally correspond to the dotted path of the app. A similar problem arises if `settings.FIRST_PARTY_APPS` contains the dotted path to the app's app config class, e.g. `myproject.myapp.apps.MyAppConfigSubclass`. But that can be worked around by putting `default_app_config` into the apps `__init__.py`, so we are not addressing that right now.
adamchainz
added a commit
that referenced
this pull request
Apr 8, 2021
adamchainz
added a commit
that referenced
this pull request
Apr 8, 2021
|
Thanks for the report. I decided to take a different approach in #62 that calls Released in 1.6.0, try it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django apps are sometimes referenced with their dotted path in
settings.FIRST_PARTY_APPS, e.g.myproject.myapp. But the label of the app config is the right most part of the path, e.g.myappwhich is not insettings.FIRST_PARTY_APPSand thus the app will not be considered a first party app.We can improve this by looking at the name of the app config, which should normally correspond to the dotted path of the app.
A similar problem arises if
settings.FIRST_PARTY_APPScontains the dotted path to the app's app config class, e.g.myproject.myapp.apps.MyAppConfigSubclass. But that can be worked around by puttingdefault_app_configinto the apps__init__.py, so we are not addressing that right now.