Support makemigrations --update from Django 4.2 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
requested changes
Jun 27, 2023
Comment on lines
16
to
20
| if update_previous_migration_paths: | ||
| super().write_migration_files(changes, update_previous_migration_paths) | ||
| else: | ||
| super().write_migration_files(changes) |
There was a problem hiding this comment.
better to avoid the else clause with an explicit Django version check: if django.VERSION >= (4, 2): ...
Django 4.2 added an optional kwarg to write_migration_files based on the --updated flag
elliott-omosheye
force-pushed
the
patch-1
branch
from
6e64cd1 to
4bd328f
Compare
for more information, see https://pre-commit.ci
|
added a test but not sure what you want in the changelog |
adamchainz
reviewed
Jul 3, 2023
src/django_linear_migrations/management/commands/makemigrations.py
Outdated
Show resolved
Hide resolved
|
Updating django-stubs for the type-checking failure: typeddjango/django-stubs#1609 |
I've written one for you. In future refer to past PR's and changelog entries to see for yourself. |
adamchainz
changed the title
adamchainz
reviewed
Jul 3, 2023
| @@ -43,6 +46,21 @@ def test_creates_max_migration_txt(self): | |||
| max_migration_txt = self.migrations_dir / "max_migration.txt" | |||
| assert max_migration_txt.read_text() == "0001_initial\n" | |||
|
|
|||
| @unittest.skipUnless(django.VERSION >= (4, 2), "--update added in Django 4.2") | |||
There was a problem hiding this comment.
Had an idea: adamchainz/django-upgrade#364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here https://github.com/django/django/pull/15669/files#diff-f2db49f63db7e5553ce472afe234288b31f1862e10b3406b58ac537ed742ffc6R330
Django 4.2 added an optional kwarg to write_migration_files based on the --updated flag.