Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dlm.E001 behaviour for detecting presence of migrations does not match create-max-migration-files behaviour #20

Closed
ahumeau opened this issue Dec 14, 2020 · 1 comment · Fixed by #22

Comments

@ahumeau
Copy link
Contributor

ahumeau commented Dec 14, 2020

Hi Adam,

First thank you for this package, it solves a problem that I have been having for some time. I am excited to try it out.

The inconsistency was introduced by 0f3741c .

create-max-migration-files checks if len(migration_details.names) > 0, the check does not.

I am not opening a PR because I want to know your opinion on wether or not it would be a better solution to move that check in MigrationDetails.has_migrations instead of just adding it in check_max_migration_files.

@adamchainz
Copy link
Owner

I feel like I had a reason at the time why I didn't push that check into has_migrations, but I can't remember why. Let's do it and see what breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants