Change reswap() type hint for method to str #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
requested changes
Mar 1, 2024
danjac
changed the title
|
Made suggested change and updated PR description. |
Instead of using a Literal set of values, any string value can be used. This allows modifiers e.g. "outerHTML show:window:top".
adamchainz
reviewed
Mar 1, 2024
src/django_htmx/http.py
Outdated
| "delete", | ||
| "none", | ||
| ], | ||
| method: str, |
There was a problem hiding this comment.
dropping trailing comma makes black format the function def on one line now
adamchainz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #421
The
HX-Swapdirective andHX-Reswapresponse header allow modifiers in addition to the method, for example:This change allows any
strvalue to be used for the method: