Add ServiceURL configuration option #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following to allow the ServiceURL configuration option as follows:
This allows for use of the library with buckets that use the S3 protocol but are hosted elsewhere. I'm using it in projects that run inside a self-hosted Kubernetes cluster and use Noobaa to provide abstracted blob storage using the S3 protocol.
This PR also refactors the configuration for the
AWSS3StorageCacheOptionsusing the named configuration options pattern, to reduce the amount of code in theAWSS3FileSystemImageCachefile.