Forgot-to-Render check for Fastmail

[michaelstepner]

Hi Adam,

I was tired of forgetting to render my Markdown emails in Fastmail, and decided to see if I could extend your excellent forgot-to-render check to the Fastmail compose interface. (Issue #317)

It almost-but-not-quite works in this initial PR. The event listeners are set up and work properly, both for clicking the Send button and for using the send hotkeys (which are the same in Fastmail as Gmail). The script correctly catches and prevents sending an unrendered email when I click Send. But if I use the ⌘+Enter hotkey, the email is sent and then Markdown Here opens the forgot to render prompt. It seems that eatEvent() is not eating the hotkey send action.

I have no prior experience with JavaScript, so I thought I would stop here and ask you for guidance. In fact, this is also my first submission to an open source project.

Michael

[adam-p]

Sorry that it's taken me forever to get back to you.

Your change looks good. I tested the hotkey and it seems to be working correctly. Maybe something has changed in Fastmail's code since then. Can you double-check that it works correctly for you now?

I see that that text-align: center change is a general improvement. It negates Fastmail's override of the usual user-agent style (that I was taking for granted). So it's effectively part of the style "reset".

I'll merge this soon if I don't hear from you. Try out the hotkey again, though, if you can.

[michaelstepner]

I tested the hotkey (⌘+Enter to send) as well and it's working correctly on my computer too. So I'd say the Forgot to Render check is now fully functional in Fastmail.

No worries about the delay, and thanks for reviewing my PR!