Add public initializer to SRPKeyPair #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done on your first OpenSource contribution |
|
Thanks! Feels good 😋 |
|
I apologise I completely forgot about this change and never did a release. Your change is now in v0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the
SRPKeyPairinitializer was private which is very unlucky if you want to manually testSRPClient.calculateSharedSecretusing hardcoded credentials, salts and keys etc. ...Another solution would be to split up the
clientKeysparameter in (SRPClient.calculateSharedSecret), but... I think it's fine just being able to create aSRPKeyPairby hand.PS: This is my very first OpenSource contribution ever 🎉