Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix central pairing and crash on clear #4522

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 31, 2021

The list_clear would crash if we tried to clear a NULL list. (It
can happen if we haven't tried to discover any services.)

The list_clear would crash if we tried to clear a NULL list. (It
can happen if we haven't tried to discover any services.)
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and central service discovery tests out OK. The discovery thing basically finishes off #3228 properly; that code looked pretty familiar.

@dhalbert dhalbert merged commit d0ba75e into adafruit:main Apr 1, 2021
@dhalbert
Copy link
Collaborator

dhalbert commented Apr 1, 2021

@tannewt This does not contain any PacketBuffer-specific fixes. Were you referring to this PR in adafruit/Adafruit_CircuitPython_BLE#91 (comment) ?

@tannewt
Copy link
Member Author

tannewt commented Apr 1, 2021

@dhalbert Nope, I haven't pushed the packet buffer fixes yet and ya, those fixes were what I was referring to. Will push them this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants