Adds a configurable timeout for builds #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
approved these changes
Sep 13, 2023
|
looks good go ahead and merge
this email was probably sent with text to speech, thank you for
understanding any typos or missing punctuation 😊
…On Wed, Sep 13, 2023 at 12:10 PM Brent Rubell ***@***.***> wrote:
cc @ladyada <https://github.com/ladyada>
This pull request adds an *optional* configurable timeout parameter,
--build_timeout, for building larger Arduino sketches or "firmware using
Arduino" (like WipperSnapper).
Without this pull request, calls to arduino-cli (and UF2 generation) from
within this script will time out and fail without any output.
Tested within Adafruit WipperSnapper PR:
adafruit/Adafruit_Wippersnapper_Arduino#488
<adafruit/Adafruit_Wippersnapper_Arduino#488>
Example failure run, without --build_timeout for ESP32 builds (which take
a while to run and fail if they timeout):
https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174986510/job/16760853258
Example successful run, with --build_timeout enabled for all builds:
https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174857439
------------------------------
You can view, comment on, or merge this pull request online at:
#160
Commit Summary
- 160a7cc
<160a7cc>
sync brentru timeout with --timeout arg
- 381d0a9
<381d0a9>
fix indentation level
- f28f8bc
<f28f8bc>
Remove timeout value from sys.argv as well
- 18ce377
<18ce377>
Merge pull request #2 from tyeth/tweak-timeout
- 011ae3e
<011ae3e>
cast
- fe15057
<fe15057>
formatting
File Changes
(1 file <https://github.com/adafruit/ci-arduino/pull/160/files>)
- *M* build_platform.py
<https://github.com/adafruit/ci-arduino/pull/160/files#diff-397680a251a8d6fb57a3be45c67a6fa50d4704abc05b95b9b106cd9901f91124>
(19)
Patch Links:
- https://github.com/adafruit/ci-arduino/pull/160.patch
- https://github.com/adafruit/ci-arduino/pull/160.diff
—
Reply to this email directly, view it on GitHub
<#160>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJINUIAXXJX43NRJJ4HO73X2HLJBANCNFSM6AAAAAA4WVYHEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ladyada
This pull request adds an optional configurable timeout parameter,
--build_timeout, for building larger Arduino sketches or "firmware using Arduino" (like WipperSnapper).Without this pull request, calls to
arduino-cli(and UF2 generation) from within this script will time out and fail without any output.Tested within Adafruit WipperSnapper PR: adafruit/Adafruit_Wippersnapper_Arduino#488
Example failure run, without
--build_timeoutfor ESP32 builds (which take a while to run and fail if they timeout): https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174986510/job/16760853258Example successful run, with
--build_timeoutenabled for all builds: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/6174857439