Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't error for (local) repos with no rev key #23

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

jepler
Copy link
Member

@jepler jepler commented Jan 29, 2024

Closes: #22

Also:

  • updates some required actions to non-deprecated versions
  • makes the CI of this repo work again

@jepler jepler requested a review from tekktrik January 29, 2024 21:50
@jepler
Copy link
Member Author

jepler commented Jan 29, 2024

After this change, running the script locally in udecimal prints

$ python /home/jepler/src/actions-ci-circuitpython-libs/print_precommit_versions.py
Using the following pre-commit hook versions:
 * https://github.com/psf/black @ 23.9.1
 * https://github.com/fsfe/reuse-tool @ v2.1.0
 * https://github.com/pre-commit/pre-commit-hooks @ v4.4.0
 * https://github.com/pycqa/pylint @ v3.0.0
 * local @ None

@jepler
Copy link
Member Author

jepler commented Jan 29, 2024

[NOW RESOLVED] The CI fails in this branch but also on main:

Directory 'actions-ci' does not exist!
CI expects the 'actions-ci-circuitpython-libs' tools being checked out to said directory.
Error: Process completed with exit code 1.

@jepler jepler force-pushed the local-repo-no-rev branch from f2e424b to a4f18b0 Compare January 29, 2024 21:56
@jepler jepler force-pushed the local-repo-no-rev branch from a4f18b0 to 4d1885f Compare January 29, 2024 21:58
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't consider local entries, so this is great!

@tekktrik tekktrik merged commit e9f0c39 into master Jan 30, 2024
1 check passed
@tekktrik tekktrik deleted the local-repo-no-rev branch February 14, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with "local" hook
2 participants