Add nice!nano development board #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
requested changes
Jun 5, 2020
src/boards/nice_nano/board.h
Outdated
| // USB | ||
| //--------------------------------------------------------------------+ | ||
| #define USB_DESC_VID 0x239A | ||
| #define USB_DESC_UF2_PID 0x0029 |
There was a problem hiding this comment.
the VID/PID is already used and we don't allow to reuse it anymore. If your board can also run circuitpython, you could apply for a set of VID/PID from Adafruit.
There was a problem hiding this comment.
I'm not familiar with Circuit Python. Is there any reason I wouldn't be able to use Circuit Python on this nRF52840 board? If not, could you direct me where to add support and apply for a VID/PID from Adafruit? Thanks!
There was a problem hiding this comment.
join circuitpyhon discords channel and ask for a donation of VID/PID to see if you are eligible for one.
|
@hathach I've added my unique PID. See: adafruit/circuitpython#3013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the configuration for my nRF52840 based development board I've created. It will be available soon. There's some bare bones documentation available here that will get extended soon: https://docs.nicekeyboards.com/#/nice!nano/
Thanks for the work that's been put into this bootloader! It's been a joy to use.