Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release task to use nested build-files assets #648

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Oct 21, 2024

This is untested, but going on the ls from the last release attempt there is clearly one folder per zip/group of assets
https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/11443957387/job/31839330119#step:3:5

@brentru
Copy link
Member

brentru commented Oct 22, 2024

@tyeth Do we need to review/merge this prior to #651 being released?

@brentru brentru self-requested a review October 22, 2024 18:45
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brentru brentru merged commit f0ebfd0 into main Oct 22, 2024
36 checks passed
@brentru brentru deleted the fix-release-task-extract-assets branch October 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants