Add retry if data not ready for SCD30 #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
scd30-read-data-at-once
branch
from
dee66d5 to
44442be
Compare
tyeth
force-pushed
the
scd30-read-data-at-once
branch
from
cdea44b to
ad60d2b
Compare
tyeth
force-pushed
the
scd30-read-data-at-once
branch
from
ad60d2b to
d1898c9
Compare
|
This should be better. @brentru ready for re-review |
brentru
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the SCD30 driver to pull the data for all metrics in one go, rather than each one in turn which caused many data_ready wait issues - appearing as no data for most metrics.