Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print ESP-IDF and arduino-esp32 core versions to the boot file #614

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Print ESP-IDF and arduino-esp32 core versions to the boot file #614

merged 2 commits into from
Aug 13, 2024

Conversation

brentru
Copy link
Member

@brentru brentru commented Aug 9, 2024

This pull request prints the ESP-IDF version and arduino-esp32 core versions to the boot text file.

@tyeth Would it be possible to double-check this works and tests OK? I used a QT Py ESP32-S2.

Resolves: #597

@brentru brentru requested a review from tyeth August 9, 2024 20:03
tyeth
tyeth requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak required

src/Wippersnapper.h Outdated Show resolved Hide resolved
src/Wippersnapper.h Show resolved Hide resolved
@tyeth
Copy link
Contributor

tyeth commented Aug 9, 2024 •
edited
Loading

Looks good, tested from CI assets, rev tft s3:

Adafruit.io WipperSnapper
Firmware Version: 1.0.0-beta.88
Board ID: feather-esp32s3-reverse-tft
MAC Address: 70:04:1D:CD:F1:10
ESP-IDF Version: v5.1.4-586-gb6b4727c58-dirty
ESP32 Core Version: 3.0.4
ERROR: Invalid IO credentials in secrets.json! TO FIX: Please change io_username and io_key to match your Adafruit IO credentials!

@brentru brentru requested a review from tyeth August 13, 2024 14:33
@brentru
Copy link
Member Author

brentru commented Aug 13, 2024

@tyeth Fixed the typo, requesting a re-review/approval prior to merging.

tyeth
tyeth approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@tyeth tyeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@brentru brentru merged commit e8e4f35 into main Aug 13, 2024
31 checks passed
@brentru brentru deleted the fix-issue-597 branch August 13, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyeth tyeth tyeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print ESP-IDF and arduino-esp32 versions to the boot_out.txt file
2 participants
@brentru @tyeth