Add a bit of logging to analogIO + fix PicoW #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brentru this is ready for review. |
tyeth
force-pushed
the
analogIO-scaling-picow
branch
from
67fce1c to
91b4984
Compare
brentru
approved these changes
Aug 14, 2024
| #elif defined(ARDUINO_ARCH_RP2040) | ||
| scaleAnalogRead = true; | ||
| _nativeResolution = 10; | ||
| #else |
There was a problem hiding this comment.
Really good catch here for undef'd architecture edge case, nice find!
Comment on lines
214
to
217
| WS_DEBUG_PRINT("Analog Pin (#"); | ||
| WS_DEBUG_PRINT(pin); | ||
| WS_DEBUG_PRINT(") read: "); | ||
| WS_DEBUG_PRINTLN(value); |
There was a problem hiding this comment.
I assume this is for debugging, make sure to remove this before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft to generate some build assets. It still needs reviewing, and the logging removed.