Adjust SGP30 init to not call IAQinit unnecessarily #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just read this through and we don't need to call IAQinit as begin does that for us. Will adjust this PR for that instead. |
tyeth
changed the title
tyeth
force-pushed
the
tweak-sgp30-init
branch
2 times, most recently
from
527f4e7 to
b8d5705
Compare
tyeth
force-pushed
the
tweak-sgp30-init
branch
from
b8d5705 to
5d0241f
Compare
|
@brentru This is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak to the SGP30 initialisation to fail if IAQ doesn't initialise successfully instead of ignoring it.Needs retesting - was in the way on another branch
Updated PR to be for the removal of the IAQinit call, as it's called here https://github.com/adafruit/Adafruit_SGP30/blob/b4a631b1d75996a4dc2b1dda07e02a8529365d33/Adafruit_SGP30.cpp#L73