-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update network port/cert support for local testing #574
Conversation
Hey @brentru can you give this one a review please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it addresses the cert issue, one question
clientID, WS._config.aio_user, | ||
WS._config.aio_key); | ||
WS._mqtt = new Adafruit_MQTT_Client( | ||
_mqtt_client, WS._config.aio_url, WS._config.io_port, clientID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyeth is WS._config.io_port
always the integer value 8883?
We default it to 8883 but it is also possible to override via Json, which
is what I need to do for the local testing on esp³², although the cert
insecure should allow local 8883 to work (if ssl setup)
…On Mon, 22 Apr 2024, 16:38 Brent Rubell, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks like it addresses the cert issue, one question
------------------------------
In src/network_interfaces/Wippersnapper_ESP32.h
<#574 (comment)>
:
> }
// Construct MQTT client
- WS._mqtt = new Adafruit_MQTT_Client(_mqtt_client, WS._config.aio_url, 8883,
- clientID, WS._config.aio_user,
- WS._config.aio_key);
+ WS._mqtt = new Adafruit_MQTT_Client(
+ _mqtt_client, WS._config.aio_url, WS._config.io_port, clientID,
@tyeth <https://github.com/tyeth> is WS._config.io_port always the
integer value 8883?
—
Reply to this email directly, view it on GitHub
<#574 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ45QFWVGLCQ26JKCLUDY6UVHFAVCNFSM6AAAAABGTAGJU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJVGE2DENBTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
Where do we do this? |
|
…secure-vm-testing Update network port/cert support for local testing
Adds support for local dev machine testing, by allowing esp32 to specify port, and also disable mqtt security checking if not staging/production url