Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network port/cert support for local testing #574

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Apr 22, 2024

Adds support for local dev machine testing, by allowing esp32 to specify port, and also disable mqtt security checking if not staging/production url

@tyeth tyeth mentioned this pull request Apr 22, 2024
@tyeth tyeth requested a review from brentru April 22, 2024 15:32
@tyeth
Copy link
Contributor Author

tyeth commented Apr 22, 2024

Hey @brentru can you give this one a review please.
Will allow me to do end to end testing locally

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it addresses the cert issue, one question

clientID, WS._config.aio_user,
WS._config.aio_key);
WS._mqtt = new Adafruit_MQTT_Client(
_mqtt_client, WS._config.aio_url, WS._config.io_port, clientID,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth is WS._config.io_port always the integer value 8883?

@tyeth
Copy link
Contributor Author

tyeth commented Apr 22, 2024 via email

@brentru
Copy link
Member

brentru commented Apr 22, 2024

We default it to 8883

Where do we do this?

@tyeth
Copy link
Contributor Author

tyeth commented Apr 22, 2024

We default it to 8883

Where do we do this?

dst.io_port = src["io_port"] | 8883;

@brentru brentru merged commit 61e3e25 into main Apr 22, 2024
32 checks passed
tyeth pushed a commit to tyeth/Adafruit_Wippersnapper_Arduino that referenced this pull request Apr 24, 2024
…secure-vm-testing

Update network port/cert support for local testing
@tyeth tyeth deleted the add-port-support-and-insecure-vm-testing branch May 2, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants