Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VL53L4CD #550

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Add VL53L4CD #550

merged 7 commits into from
Apr 19, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Feb 12, 2024

Currently Untested

@tyeth tyeth force-pushed the add-VL53L4CD branch 3 times, most recently from 40545f3 to 528be54 Compare February 16, 2024 12:54
@tyeth tyeth force-pushed the add-VL53L4CD branch 9 times, most recently from bf4a20b to c405b7c Compare March 29, 2024 13:10
@tyeth tyeth marked this pull request as ready for review April 5, 2024 11:36
platformio.ini Outdated Show resolved Hide resolved
@tyeth tyeth changed the title WIP: Add VL53L4CD Add VL53L4CD Apr 5, 2024
@tyeth tyeth force-pushed the add-VL53L4CD branch 4 times, most recently from fedf3ba to 18ff2d1 Compare April 10, 2024 15:40
@tyeth tyeth requested a review from brentru April 10, 2024 15:41
@tyeth
Copy link
Contributor Author

tyeth commented Apr 10, 2024

@brentru ready for review please

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth Requesting the following changes

@tyeth tyeth force-pushed the add-VL53L4CD branch 2 times, most recently from a75bfc1 to 53c2ca2 Compare April 16, 2024 17:34
tyeth added 3 commits April 16, 2024 21:38
* VL53L4CD - Remove sleep interval + clear interrupt
* VL53L4CD: tweak SignalThreshold to 50
* VL53L4CD with debug printing if failed read
@tyeth
Copy link
Contributor Author

tyeth commented Apr 19, 2024

@brentru if you wouldn't mind re-reviewing this one

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approving this and requesting one minor change. Merge in when you've added it.

@tyeth tyeth merged commit f51d4ac into adafruit:main Apr 19, 2024
32 checks passed
@tyeth tyeth deleted the add-VL53L4CD branch May 31, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants