Fix prvPeriod in AnalogIO - starting value 1628136801 on SAMD #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
reviewed
Jan 17, 2024
| @@ -145,6 +145,7 @@ void Wippersnapper_AnalogIO::initAnalogInputPin( | |||
| if (_analog_input_pins[i].enabled == false) { | |||
| _analog_input_pins[i].pinName = pin; | |||
| _analog_input_pins[i].period = periodMs; | |||
| _analog_input_pins[i].prvPeriod = 0L; | |||
There was a problem hiding this comment.
@tyeth Is there anywhere else in the analogio or digitalio class this bug is present?
|
Looked like that was the only initialisation route, and I spotted the
difference in usage of prvPeriod (which seemed best solution) between
analogIO and digitalIO (which looks fine to me)
…On Wed, 17 Jan 2024, 16:04 Brent Rubell, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/components/analogIO/Wippersnapper_AnalogIO.cpp
<#539 (comment)>
:
> @@ -145,6 +145,7 @@ void Wippersnapper_AnalogIO::initAnalogInputPin(
if (_analog_input_pins[i].enabled == false) {
_analog_input_pins[i].pinName = pin;
_analog_input_pins[i].period = periodMs;
+ _analog_input_pins[i].prvPeriod = 0L;
@tyeth <https://github.com/tyeth> Is there anywhere else in the analogio
or digitalio class this bug is present?
—
Reply to this email directly, view it on GitHub
<#539 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ4YYFASW32UYX5VFTOTYO7Y7FAVCNFSM6AAAAABB6Y7V3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRXGY2DQMJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
.com>
|
|
We are going to refactor these two classes during the api-v2 transition so I wouldn't worry too much about that. Thanks for taking a look, LGTM. |
brentru
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating this out from #538