Fix ESP8266 Compiler Warnings #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s: 'long unsigned int' and 'long int' [-Wsign-compare]
|
@tyeth Could you please review this PR? If it is OK, you can merge it in. I did touch some core API things (mostly marking unused parameters to avoid warnings) so it may require a functional test. For any PRs failing on ESP8266: Merge this PR after and see if they work |
tyeth
reviewed
Aug 17, 2023
tyeth
reviewed
Aug 17, 2023
There was a problem hiding this comment.
One missed, see tyeth@9532d0b
There was a problem hiding this comment.
Also a long vs uint32 warning, about sensor period.
tyeth
requested changes
Aug 17, 2023
There was a problem hiding this comment.
@brentru Looks good, makes sense removing the i2c bus number too for now.
Suggested changes (can't seem to suggest or comment in non-touched files + areas)
|
Implemented changes from tyeth@9532d0b in commit ece56dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to reduce ESP8266 builds failing by reducing the amount of compiler warnings produced such as: