Fix and refactor analog input class #407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
Wippersnapper_AnalogIO
class:processAnalogInputs()
toupdate()
to match other, newer, component class APIs. Large refactoring for readability and maintainability around this new methodencodePinEvent
func to encode and publish signal message to IOinitAnalogOutputPin
, superseded by PWM classconfigurePinRequest()
intoconfigAnalogInPinReq()
andconfigureDigitalPinReq()
Resolves:
#406
#403 (needs testing!)
Required tests prior to merging: