Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing my code for optimization, I noticed that gamma correction is (incorrectly) only performed on NeoPixels:
For DotStar strands, where the default of
neoPixelPtr
is set tonullptr
, this line will not execute at all.This pull request adds a new getter function,
getGammaCorrectedColor()
which returns the gamma-correct RGB hex value.getGammaCorrectedColor()
works with both NeoPixel and DotStar strands and also provides error handling.