-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Servo class and fix ESP32 servo issue on beta 55 #372
Conversation
Artifacts are ready for testing + checks passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only necessary change is the misleading error message, the rest is me having fun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@brentru ok this is live on staging for you to test! |
@lorennorman Tested on hardware, OK'ing deploy to production Prod
Staging
|
@brentru I am wondering if this change has caused "sync" to not do the right thing now, can you test that easily? To be clear: if there is already a value on the Servo's feed, the device should move to that position on sync (right?) I'm worried I broke this and need a further tweak. |
Does not sync on staging |
getServoIdx
for performing index lookup