Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Addressable Pixel API #370

Merged
merged 76 commits into from
Jan 23, 2023
Merged

Add Addressable Pixel API #370

merged 76 commits into from
Jan 23, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Nov 18, 2022

Adds the ability for a WipperSnapper device to interface with a strand (size n) of addressable RGB Pixels (DotStar, NeoPixel).

Note: This PR only supports setting an entire strand to one-color ("filling a strand"). WipperSnapper does not yet support individually addressing each pixel or pixel animation/sequence.

Address adafruit/Wippersnapper_Protobuf#90

@brentru brentru requested a review from caternuson January 20, 2023 18:36
@brentru
Copy link
Member Author

brentru commented Jan 20, 2023

@caternuson Could you please review the ws_pixels class and code? Thanks in advance!

@caternuson
Copy link

Gave the code a very cursory look, only looking at the NeoPixel/DotStar library calls being done. The setup calls done in ws_pixels::addStrand() look OK. The fill calls in ws_pixels::fillStrand() look OK.

@brentru brentru merged commit 6922dd4 into adafruit:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants