Add vl53l0x driver - finish work by Afp316 #291

[tyeth]

This just finishes off the fine work by @afp316 in #291
Rebased off of latest main, amended last commit to remove .pio/.vscode changes, ran clang-format.

[brentru]

Build failing due to adafruit/Adafruit_MQTT_Library#217

[tyeth]

Not sure how to retrigger workflow, but just read about hash sign-off so here goes:
#sign-off

[brentru]

I'm not familiar with #sign-off...

On the workflow, https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/3451873666 you should be able to re-run jobs?

[tyeth]

Sadly not available, I think there's a repository or Org setting for allowing workflow runs from pull requests / forks.

This was related but maybe not quite the one: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#enabling-workflows-for-forks-of-private-repositories

[tyeth]

Curious, builds happily on some, and on others the same warning seems fatal (or did they just time out?), in the adafruit vl53l0x library about initialisation. https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/3473545620/jobs/5805679630#step:8:75

[brentru]

-Wmissing-field-initializers is a warning being treated (correctly) as an error with the ESP32 compiler. Please open an issue over on the Adafruit vl53l0x repo, include the warning and log output, tag me, and I'll (or an engineer from adafruit) will fix it.

[tyeth]

Before I do, I'd like to know why does it compiles the build/UF2 image successfully on the other ESP32 builds, like the one I linked the S2-TFT, with the warning still present?
Also how should it be fixed, does the .h file that defines the struct get defaults specified, or does on define only on each initialisation? Is it ever okay to just disable that warning for a line like that initialisation?

[brentru]

It did pass, but the build warnings were still thrown: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/3473545620/jobs/5805679630#step:8:73

I'm not sure why at the moment..

Also how should it be fixed, does the .h file that defines the struct get defaults specified, or does on define only on each initialisation

When a struct is initialized, it must contain all members within the brace-enclosed list of initializers

• https://github.com/adafruit/Adafruit_VL53L0X/blob/master/src/vl53l0x_def.h#L220

Is it ever okay to just disable that warning for a line like that initialisation?

Not if we can fix it :)

[tyeth]

So there was a missing bit in wippersnapper related to the setting of the time of last poll for the proximity sensor type.

Now just another initialisation warning that I'll stick up an issue for or fix eventually, but the sensor works for now on address 29.
Not really happy with the reliability of the sensor in default config so I've selected high accuracy, but may experiment with other libraries too. I think for now it makes sense to leave as is, but long term offer the options of long_range, high_speed and high_accuracy.

The Dev flag in components with the banners is great :)

[brentru]

@tyeth Read over the PR, some comments..

[brentru]

@tyeth - OK, addressed in adafruit/Adafruit_VL53L0X#59 and released in https://github.com/adafruit/Adafruit_VL53L0X/releases/tag/1.2.1. Arduino Lib manager will pick this up (probably later today) and I will re-kick the CI.

Thanks for being patient.

[brentru]

@tyeth This is failing clang/doxy (https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/3517128928/jobs/6038336339). Should be ready to go after. Thanks for your patience. I've also fixed the flaky behavior for building the ESP32-Sx platforms via the CI.

[tyeth]

Wow green lights across the board, a more rare and pleasant sight that we might like to admit 📉
Congratulations on the CI work🥇 Just done the doxygen fix so that should be it!

[afp316]

Nice job and thank you both for your hard work and patience. I couldn't figure out the Clang and doxygen stuff.

…

On Thu, Dec 1, 2022 at 10:21 AM Tyeth Gundry ***@***.***> wrote: Wow green lights across the board, a more rare and pleasant sight that we might like to admit 📉 Congratulations on the CI work🥇 Just done the doxygen fix so that should be it! — Reply to this email directly, view it on GitHub <#363 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXAAGVQNQKJ2EICXDJYOQF3WLC7AVANCNFSM6AAAAAAR6NF2JQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[brentru]

Great work - thank you both. Will be included in next release.