Platformio readme and dependency changes #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyeth I'm hesitant to include this as it uses the DallasTemp library and we install that from scratch in the CI. |
|
Yeah don't include it yet, I wanted to ask why it was done that way around,
i.e. in CI via a git clone and not listed in library.properties?
I'll remove the commit happily too, just needed it to test building in
arduino and platformIO in the Sandbox.
…On Tue, 1 Nov 2022 at 17:35, Brent Rubell ***@***.***> wrote:
@tyeth <https://github.com/tyeth> I'm hesitant to include this as it uses
the DallasTemp library and we install that from scratch in the CI.
—
Reply to this email directly, view it on GitHub
<#357 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ4Z4GEJXCAE332DJA5TWGFIFJANCNFSM6AAAAAARTFE5KI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Script added to assist in platformio setup adafruit#336
tyeth
force-pushed
the
platformio-fixes
branch
from
2f390bb to
99e458d
Compare
tyeth
force-pushed
the
platformio-fixes
branch
from
99e458d to
7965bd4
Compare
|
This seems no longer needed thanks to #446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #336