fix crash caused by incorrectly set broker url in mqtt object #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta 50 and Beta 51 experienced crashing during the MQTT connection process:
This was due to a call to
new Adafruit_MQTT_Client()
. The pointer to the char array storing the MQTT broker URL was not set unless the user was using the development (staging) server. This code was changed when we switched to remove MQTTS due to the fingerprinting requirement for ESP8266 boards.This pull request
Output of this PR running with incorrect Adafruit IO credentials:
Output of this PR running with correct Adafruit IO credentials: