Add VEML7700 Lux sensor #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to say I've run the same code on arduino on an esp32-s3 ttgo-dsiplay-s3 and it's working fine, sensible readings returned. |
|
Code looks good, stalled on adafruit/Adafruit_VEML7700#21 (requirement) |
|
Resolving in adafruit/Adafruit_VEML7700#22, will re-run this PR once re-released. |
brentru
reviewed
Oct 13, 2022
brentru
reviewed
Oct 13, 2022
brentru
approved these changes
Oct 13, 2022
|
Failed testing, forgot to specify which i2c. Retesting |
|
Yeah, passed testing, sensor added and returning sane values. |
|
Merging in. This will be released with Beta 52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Vishay VEML7700-TR
Ambient Light Photo Sensor, I2C Output, 550nm, 0-120 000lx Range, 2.5V to 3.6V Supply,
https://www.adafruit.com/product/5378
Relates to adafruit/Wippersnapper_Components#91
Closes adafruit/Wippersnapper_Components#89