-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add driver definition for Sensirion SHTC3 #342
Conversation
Uses existing arduino-sht driver from sensirion. SHTC3 is available on address 0x70. See also adafruit/Wippersnapper_Components#72
No version bump included, I'm assuming you'll squeeze that in for v52 @brentru, but no worries if not. |
@tyeth I've made this live on IO so you can test it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge when CI passes
@tyeth I'm going to include this PR and #340 in b52. Could you bump the version number here: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/src/Wippersnapper.h#L70 and here: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/library.properties#L2 |
Blessed, done. Thanks @brentru |
@tyeth Were you able to test this out on hardware? |
Wow that's a busy QT Py. Going to re-run the flake job.. |
Thanks @brentru, apologies for not running clang/doxygen before. I've now run like the CI pipeline does, and made appropriate fix. I was getting a warning for wippersnapper.h line 300 should not be twolines, but I guess adafruit codestyle length. I've left it for now until I understand the rules better. |
@tyeth could you resolve the conflicts and we'll merge in? |
@tyeth Do you need this immediately? If not, it'll be published in the next release along with a few bugfixes. |
Not at all. Just keen to close things before hacktoberfest ends 😬 |
Uses existing arduino-sht driver from sensirion, same as SHT3x/40.
SHTC3 is available on address 0x70.
See also adafruit/Wippersnapper_Components#72