Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add driver definition for Sensirion SHTC3 #342

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Oct 4, 2022

Uses existing arduino-sht driver from sensirion, same as SHT3x/40.
SHTC3 is available on address 0x70.
See also adafruit/Wippersnapper_Components#72

Uses existing arduino-sht driver from sensirion.
SHTC3 is available on address 0x70.
See also  adafruit/Wippersnapper_Components#72
@tyeth
Copy link
Contributor Author

tyeth commented Oct 4, 2022

No version bump included, I'm assuming you'll squeeze that in for v52 @brentru, but no worries if not.

@brentru
Copy link
Member

brentru commented Oct 5, 2022

@tyeth I've made this live on IO so you can test it out.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when CI passes

@brentru
Copy link
Member

brentru commented Oct 5, 2022

@tyeth
Copy link
Contributor Author

tyeth commented Oct 5, 2022

Blessed, done. Thanks @brentru

@brentru
Copy link
Member

brentru commented Oct 5, 2022

@tyeth Were you able to test this out on hardware?

@tyeth
Copy link
Contributor Author

tyeth commented Oct 6, 2022

Sorry, I meant to yesterday and got distracted. I have now tested it, and on a fairly populated bus, with the si7021, aht20, sht31 (x2), and SHTC3.
20221006_114747
Please excuse the jankyness.

@brentru
Copy link
Member

brentru commented Oct 6, 2022

Wow that's a busy QT Py. Going to re-run the flake job..

@tyeth
Copy link
Contributor Author

tyeth commented Oct 7, 2022

Thanks @brentru, apologies for not running clang/doxygen before. I've now run like the CI pipeline does, and made appropriate fix.

I was getting a warning for wippersnapper.h line 300 should not be twolines, but I guess adafruit codestyle length. I've left it for now until I understand the rules better.
image

@brentru
Copy link
Member

brentru commented Oct 20, 2022

@tyeth could you resolve the conflicts and we'll merge in?

@brentru brentru merged commit e2a8c65 into adafruit:main Oct 24, 2022
@brentru
Copy link
Member

brentru commented Oct 24, 2022

@tyeth Do you need this immediately? If not, it'll be published in the next release along with a few bugfixes.

@tyeth
Copy link
Contributor Author

tyeth commented Oct 24, 2022

Not at all. Just keen to close things before hacktoberfest ends 😬
I'll finish the animation and other spinning plates...

@tyeth tyeth deleted the add-shtc3 branch January 11, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants