-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add si7021 #319
Add si7021 #319
Conversation
@tyeth Please run doxygen across |
@tyeth You should be able to test this PR with Adafruit IO at this point. The artifacts for this build, for all of the boards we test against, are on https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/actions/runs/3040113913 under "build-files". |
Thanks, had to add one more commit. It was strange, I saw no error in console (using debug mode on in demo sketch), because I was just returning true after a failed init I guess, but it would stall at the ping/application runs and then watchdog would hard reset. |
@tyeth Could you bump the version number here https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/src/Wippersnapper.h#L70 and here https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/library.properties#L2 to beta 49? |
Blessed, done, thank you. Wondered where that was set :) |
@tyeth Were you following https://learn.adafruit.com/how-to-add-a-new-component-to-adafruit-io-wippersnapper at all? Does it not contain info about where the version number is set? Any feedback to add? |
I was following the guide, I'll admit skimming back and forth on the i2c driver page, but I dont remember version number, and having just rechecked it's not there. I assumed CI would do it, but I also noticed it was asking in the Devices page to update firmware (when testing) so probably add to that section of the guide: https://learn.adafruit.com/how-to-add-a-new-component-to-adafruit-io-wippersnapper/adding-an-i2c-component-driver#testing-your-new-sensor-3111513 I found it relatively easy to follow, just had an issue with clang and doxygen, but to be honest I had issues there because of windows and not using the commandline / taking shortcuts (using doxywizard probably was a bad idea) and it turned up loads of false positives so I had it misconfigured. I should have avoided windows and gone to linux/wsl but was on the slow laptop 🤷 so used vscode and :ahem: blagged it / manually linted |
Thanks for the feedback!
I'll add this, thanks
and this too! |
This adds the Silicon Integrated Si7021 Temperature and Humidity driver.
https://www.adafruit.com/product/3251
Using adafruit-si7021 arduino library.
Device file is basically copy-pasta from SCD40 with changed names/methods and an added destructor like the guide suggests.
Matching component adafruit/Wippersnapper_Components#73