Fix and merge binaries for ESP32 Web Tool #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request successfully tested on hardware: QT Py ESP32 Pico, Feather ESP32v2, Feather ESP32 Huzzah |
brentru
added a commit
to adafruit/Wippersnapper_Boards
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP Web Tools do not work while uploading binaries at offsets after the Arduino-ESP32 BSP v2.0.4 release. @makermelissa and I believe its due to web tools not patching the binary with flash size/freq, while esptool.py does.
This PR provides a patch that:
merge_bincmd to be uploaded at 0x0. WipperSnapper_Boards definitions for these boards will be updated with the newstructureand offset.Subsequent PR(s) will reduce the number of actions steps, and map the flash frequency and flash size to the appropriate esp32 board.