Fix WipperSnapper GCC bugs for ESP32-2.0.4 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Jul 11, 2022
| @@ -365,7 +365,8 @@ void WipperSnapper_Component_I2C::deinitI2CDevice( | |||
| for (iter = drivers.begin(), end = drivers.end(); iter != end; ++iter) { | |||
| if ((*iter)->getI2CAddress() == deviceAddr) { | |||
| // Delete the object that iter points to | |||
| delete *iter; | |||
| // delete *iter; | |||
| *iter = nullptr; | |||
There was a problem hiding this comment.
this does not delete? which is OK, as long as its not allocated by you
|
@makermelissa Yes. https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/.github/workflows/build-clang-doxy.yml#L38 was added in this PR as it temporarily fixes espressif/arduino-esp32#6962 (I've integrated this patch only for the feather in the brentru repo). The brentru/mqtt dep is also supposed to be there, but it's a much older dependency. I need to check over what changes I've made that warrant it being brentru/ instead of adafruit/. |
|
Thanks, just checking. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no_warnflag on ci-arduino runsWill release once #281 is also tested and in-place