Skip to content

Commit

Permalink
[SD] Resolve all Wokwi test issues, all green
Browse files Browse the repository at this point in the history
  • Loading branch information
brentru committed Dec 27, 2024
1 parent 75b117b commit a2bcc7d
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/provisioning/sdcard/ws_sdcard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,7 @@ void ws_sdcard::waitForSerialConfig() {
_serialInput.trim();

// Print out the received JSON string
// TODO: REMOVE this for the PR
// TODO: REMOVE this for the PR
WS_DEBUG_PRINT("[SD][Debug] JSON string received!");
if (_use_test_data) {
WS_DEBUG_PRINTLN("[from json test data]");
Expand Down
1 change: 0 additions & 1 deletion tests/scenarios/offline/test-log-analogin.scenario.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ steps:
- wait-serial: '[SD] Waiting for incoming JSON string...'
- write-serial: '{"exportVersion": "1.0.0", "exportedBy": "wokwi", "exportedAt": "2024-10-28T18:58:23.976Z", "exportedFromDevice": {"board": "metroesp32s3", "firmwareVersion": "1.0.0-beta.93", "referenceVoltage": 2.6, "totalGPIOPins": 11, "totalAnalogPins": 6}, "components": [{"componentAPI": "analogio", "name": "Analog Pin", "pinName": "D14", "type": "analog_pin", "mode": "ANALOG", "direction": "INPUT", "sampleMode": "TIMER", "analogReadMode": "PIN_VALUE", "period": 5, "isPin": true}], "checksum": 149}'
- write-serial: '\n'
- wait-serial: '[SD] Valid JSON string received!'
- wait-serial: '[analogio] Added new pin:'
- wait-serial: 'Pin Name: 14'
- wait-serial: 'Period: 5000.00'
Expand Down
2 changes: 1 addition & 1 deletion tests/scenarios/offline/test-log-digital-in.scenario.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ steps:
- wait-serial: '[SD] Waiting for incoming JSON string...'
- write-serial: '{"checksum":183,"components":[{"componentAPI":"digitalio","direction":"INPUT","isPin":true,"mode":"DIGITAL","name":"Button (D4)","period":5,"pinName":"D4","pull":"UP","sampleMode":"TIMER","type":"push_button"}],"exportVersion":"1.0.0","exportedAt":"2024-10-28T18:58:23.976Z","exportedBy":"wokwi","exportedFromDevice":{"board":"metroesp32s3","firmwareVersion":"1.0.0-beta.93","referenceVoltage":2.6,"totalAnalogPins":6,"totalGPIOPins":11}}'
- write-serial: '\n'
- wait-serial: '[SD] Valid JSON string received!'
- wait-serial: '[SD] JSON string received!'
- wait-serial: '[digitalio] Added new pin:'
- wait-serial: 'Pin Name: 4'
- wait-serial: 'Period: 5000'
Expand Down
1 change: 0 additions & 1 deletion tests/scenarios/offline/test-log-ds18b20.scenario.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ steps:
- wait-serial: '[SD] Waiting for incoming JSON string...'
- write-serial: '{"exportVersion": "1.0.0", "exportedBy": "wokwi", "exportedAt": "2024-10-28T18:58:23.976Z", "exportedFromDevice": {"board": "metroesp32s3", "firmwareVersion": "1.0.0-beta.93", "referenceVoltage": 2.6, "totalGPIOPins": 11, "totalAnalogPins": 6}, "components": [{"componentAPI": "ds18x20", "name": "DS18B20: Temperature Sensor", "sensorTypeCount": 2, "sensorType1": "object-temp-fahrenheit", "sensorType2": "object-temp", "pinName": "D6", "sensorResolution": 12, "period": 5}], "checksum": 34}'
- write-serial: '\n'
- wait-serial: '[SD] Valid JSON string received!'
- wait-serial: '{"timestamp":0,"pin":"D6","value":0,"si_unit":"OBJECT_TEMPERATURE"}'
- wait-serial: '{"timestamp":0,"pin":"D6","value":32,"si_unit":"OBJECT_TEMPERATURE_FAHRENHEIT"}'

0 comments on commit a2bcc7d

Please sign in to comment.