Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Adafruit devs :)
I'm working with a Pine64 Pinephone, and noticed that
PlatformDetect
was identifying my device as aPINE64
single-board computer. I started looking into the logic and noticed a few things:/proc/device-tree/model
and sets the board id based on whether that string contains some substring.Pine64 PinePhone (1.2)
. The way theif-elif
statement is structured caused the board id to always bePINE64
. I changed the structure to work for my device, but my change will likely break this for a Pine64 SBC.Perhaps someone could give me some ideas about how to redo the logic to be generic for all Pine64 device? It would be helpful to see the contents of
/proc/device-tree/model
for all the Pine64 devices thatPlatformDetect
supports. One idea might be to compare only on the second word of the model name.Next up is PR
Blinka
to include the PinePhone. Thanks!