Pull request to make it work in K210 (Maix Sipeed and compatible boards, Maixduino) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified library so that it refuses to build on an unknown architecture instead of building and then doing nothing. Added kendryte k210 support, which might not be optimal, but works for me. Test with Seeed's https://github.com/Seeed-Studio/ArduinoCore-k210/ and Sipeed Maix Bit board
enjambracao pra funcionar
|
hi this PR broke the other platforms, please check |
|
Thanks @ladyada, my fault. I've just sent a correction |
ladyada
approved these changes
Aug 11, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've just forked the library and adjusted it to work with Maixduino too.
As the library isn't mine I think it worths a quick manual revision to se if it doesn't break anything. From what I've seen it seems to work ok.
I have the hardware to test if you merge it.
Cheers,