Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make chip_select pin optional in SPI fourwire #125

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

janvolck
Copy link
Contributor

@janvolck janvolck commented Dec 31, 2023

on Odroid C4 the chip_select is controlled by the spi_meson_spicc driver, in case the SPI_CS0 is used as chip_select pin in the FourWire class Resource Busy exceptions are thrown.

on Odroid C4 the chip_select is controller by the spi_meson_spicc driver, in case the SPI_CS0 is used as chip_select pin in the FourWire class Resource Busy exceptions are thrown.
on Odroid C4 the chip_select is controller by the spi_meson_spicc driver, in case the SPI_CS0 is used as chip_select pin in the FourWire class Resource Busy exceptions are thrown.
@tekktrik tekktrik requested a review from makermelissa January 2, 2024 17:41
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, I like to leave the interface consistent with CircuitPython displayio. However, because linux can add its own set of challenges, this change makes sense.

@makermelissa makermelissa merged commit 448a5d5 into adafruit:main Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants