Enable the axis remapping functionality already present in begin(). #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed the associated enums. They were otherwise not used and excessively restricted axis remapping. Default parameters are provided so existing code should be unaffected.
|
Similar code was merged in via #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The axis remapping functionality of the BNO055 was already added by a previous contributor, though left commented out. I re-enabled it and added additional parameters to begin() to pass in the required values. Default values for these parameters ensure existing client code will still work as before.
I also removed the associated enums. They were not used anywhere since the code was originally commented out, and simplified the remapping configurations to a degree that was restrictive.
No known limitations since it's all I2C.
Tested both default and remapped operation with a Feather M0.