[FEATURE] Add support for APDS9960 clones #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for more than one chip id and improve chip detection to initialize clones properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for more than one chip id and improve chip detection to initialize clones properly.
Adafruit_APDS9960.h:
Use defines to define more than one chip id and make handling of these easier.
Adafruit_APDS9960.cpp:
Improve chip detection part in Adafruit_APDS9960::begin() to handle more than one chip id and allow clones with different id than the genuine chip to be used without a failing initialization.
Should work with every platform and shouldn't break any existing code as the changes are minor ones.
Tested with a Chinese clone of the APDS9960 without problems.