Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape variables in action.yml #15

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Escape variables in action.yml #15

merged 2 commits into from
Oct 10, 2019

Conversation

ad-m
Copy link
Owner

@ad-m ad-m commented Oct 10, 2019

No description provided.

@ad-m ad-m changed the title Escape variables in action.yml [WIP] Escape variables in action.yml Oct 10, 2019
@ad-m ad-m changed the title [WIP] Escape variables in action.yml Escape variables in action.yml Oct 10, 2019
@ad-m ad-m requested a review from tenhobi October 10, 2019 21:20
@ad-m
Copy link
Owner Author

ad-m commented Oct 10, 2019

Fix build on error:

##[error]Fail to load /home/runner/work/_actions/ad-m/git-push-action/master/action.yml
Current runner version: '2.159.0'
Prepare workflow directory
Prepare all required actions
Download action repository 'actions/checkout@v1'
Download action repository 'ad-m/git-push-action@master'
##[error](Line: 9, Col: 18):
##[error](Line: 9, Col: 18): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
##[error]Fail to load /home/runner/work/_actions/ad-m/git-push-action/master/action.yml

@rachmari, where is the variables evaluation in description field in the file action.yml documented and explained? I am asking for documentation to minimize questions in related areas in the future. Documentation available at https://help.github.com/en/articles/metadata-syntax-for-github-actions#description mention it as string not as variable-substituted text. It looks as something build on top of plain YAML files ( https://stackoverflow.com/questions/41620674/use-placeholders-in-yaml ). If I follow the documentation well, the variables are supported in workflow/*.yml, not in action.yaml.

Edit: Action can have variables as documented at https://help.github.com/en/articles/contexts-and-expression-syntax-for-github-actions .

@tenhobi
Copy link
Contributor

tenhobi commented Oct 10, 2019

Where do you get this error output from? I cannot see it anywhere. Thx. :-)

Edit: see you response now, thx

@ad-m
Copy link
Owner Author

ad-m commented Oct 10, 2019

Try use our action from branch master . I use our action to per-hour update repository and then I realize that we broke action.

@ad-m ad-m merged commit 0f72585 into master Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the syntax-action branch October 10, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants