Support (almost) arbitrary expressions for FILTER and HAVING #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expressions. It is not yet integrated and yet requires proper size and cost estimates.
…nowledge base TODO: - Unit tests don't compile yet - language filters don't work yet - The size and cost estimates of the filters are not implemented yet, so the query planning is broken.
…se we have to fight with the nested matchers.
…maining TODOs: [] Early failure with readable messages on unsupported use of `LANG()`. [] Early failure with readable messages on use of expressions that don't return a boolean type. [] Proper size and cost estimates from the expressions that can be used as filters.
…fficiently implement this right now).
TODO: There is a "Literal" class in the parser which should be "TripleComponent" to make the stuff work consistently. that would be the next step.
TODO: - Remaining size and cost estimates. - Earlier error messages.
…or now, as this is a whole other story.
The only thing that is really not working is HAVING(AGGREGATE(?something)) Because the ?something variable is not visible anymore after the GROUP BY. We need a different approach for this.
(multiple having clauses, filter on full scan). TOODO: Add e2e tests for these bugs.
I should really consider splitting this up into "preparing", "actual", and "unrelated" work.
added some comments. Early failure (during the parsing) for unsupported `LANG` function usages.
hannahbast
requested changes
Oct 12, 2022
hannahbast
requested changes
Oct 12, 2022
hannahbast
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes #800
TODOs:
LANG().Early failure with readable messages on use of expressions that don't return a boolean type.Support implicit conversion of all possible result types tobool.