-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse WHERE clause using ANTLR #749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks very nice. I gave it a first long round of reviews, let me know when you want to talk about any of it.
Co-authored-by: joka921 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this is really getting in shape.
I have left some remarks, and some of this we should maybe discuss in person.
But I think you should have enough to do:)
Co-authored-by: joka921 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost done. We have already tried this out yesterday and especially @hannahbast liked it very much. There is one slight issue with the new way you call addLanguageFilter
but that is because that function was always kind of broken and will already be fixed before this gets merged (not your fault).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice,
I think we are converging towards merging:)
Co-authored-by: joka921 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This is a very important milestone towards more correct and cleaner parsing!
@Qup42 BTW, I already told Johannes, but I didn't tell you yet, Julian: Thank you very much for your work on this PR and the associated ones! It's a major milestone for QLever. In particular, it allowed me a happy update of this page: https://github.com/ad-freiburg/qlever/wiki/Current-deviations-from-the-SPARQL-1.1-standard . And it's the basis for many other improvements that had to wait so far because we didn't have a proper SPARQL parser. |
Parse
whereClause
in ANTLR. This is one fairly big connected chunk of the grammar.The parsing should already work. It is live in the
SparqlParser
.TODO:
std::pair<...>
return types into structs.valuesClause