Add support for a as rdf:type alias #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbast
approved these changes
May 21, 2022
There was a problem hiding this comment.
Thank you for this workaround (until we have the new parser) for this sorely missed feature!
The code looks good to me and I tested it on QLever DBLP and it works fine: https://qlever.cs.uni-freiburg.de/dblp/uFQztf
@joka921 If you don't object, I will merge it later today.
joka921
approved these changes
May 21, 2022
There was a problem hiding this comment.
I think since you added it as the last of the regexes in the parser it should not break anything else. Thanks for the quick fix.
@hannahbast Feel free to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an additional step the actual parsing could fully or partly be switched to ANTLR