Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the size estimate from the cache. #1736

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Jan 30, 2025

No description provided.

@joka921 joka921 marked this pull request as ready for review January 30, 2025 08:22
Signed-off-by: Johannes Kalmbach <[email protected]>
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (50e5108) to head (e731afe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
- Coverage   89.95%   89.94%   -0.02%     
==========================================
  Files         393      395       +2     
  Lines       37639    37620      -19     
  Branches     4233     4228       -5     
==========================================
- Hits        33859    33836      -23     
- Misses       2480     2489       +9     
+ Partials     1300     1295       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I will test this once again, write a description and then merge

@sparql-conformance
Copy link

Conformance check passed ✅

Test Status Changes 📊

Number of Tests Previous Status Current Status
38 Failed Passed

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=e731afecfc773443dcde43e7d5135ab75fb4ed87&prev=49934c0013cc1861d665ec3647e748df3b593457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants