Add datasets from parameters for Query and Update #1714
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1714 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 393 393
Lines 37614 37626 +12
Branches 4231 4231
=======================================
+ Hits 33823 33837 +14
+ Misses 2494 2491 -3
- Partials 1297 1298 +1 ☔ View full report in Codecov by Sentry. |
src/engine/Server.cpp
Outdated
| } else { | ||
| AD_FAIL(); |
There was a problem hiding this comment.
Can this statically happen?
Otherwise you can replace the else if constexpr by else static_assert
There was a problem hiding this comment.
What do you mean by doing this statically? The comment is now applied and also a static_assert(std::is_same_v<Operation, Query> || std::is_same_v<Operation, Update>) at the beginning (which my IDE marked at some time). What would be a good style for doing this (the static_assert in the else is redundant now)?
There was a problem hiding this comment.
I don't mind the redundant static assert in the beginning.
The one in the beginning gives nice documentation + error messages,
And in the if-else it is useful to prevent bugs etc. So I really like the way it is now.
src/engine/Server.cpp
Outdated
| return operation.update_; | ||
| } else { | ||
| AD_FAIL(); | ||
| } |
|
There was one random test failure in a run that was most likely not from this PR: https://github.com/ad-freiburg/qlever/actions/runs/12833696568/job/35789345340?pr=1714 |
src/engine/Server.cpp
Outdated
| } else { | ||
| AD_FAIL(); |
There was a problem hiding this comment.
I don't mind the redundant static assert in the beginning.
The one in the beginning gives nice documentation + error messages,
And in the if-else it is useful to prevent bugs etc. So I really like the way it is now.
# Conflicts: # src/engine/Server.cpp # src/engine/Server.h
Conformance check passed ✅No test result changes. |
|
The default graphs and named graphs for a query or update can now also be specified as parameters to the HTTP GET/POST request (in addition to specifying them via
FROM [NAMED]clauses, which was also supported previously.In particular, the parameters
default-graph-uriandnamed-graph-uriare now supported by queries, and the parametersusing-graph-uriandusing-named-graph-uriare supported by updates. Note that these parameters are part of the standardized SPARQL protocol.Fixes #1712