Implement function `timezone()` #1386

realHannes · 2024-06-30T15:03:12Z

This function returns a literal of type xsd:DayTimeDuration.
This commit also efficiently implements literals of type xsd:DayTimeDuration in general. They are stored inside the same class that also stores Date values, so they are folded directly into the ValueID.

Co-authored-by: Johannes Kalmbach <[email protected]>

…number conv.

…neral implementation

Co-authored-by: Johannes Kalmbach <[email protected]>

…ng correct prefix in Constants.h

…bleExpression

…d::from_chars()

codecov · 2024-06-30T15:27:35Z

Codecov Report

Attention: Patch coverage is 97.72210% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (14d6e1c) to head (52fecaa).

Files	Patch %	Lines
src/util/DateYearDuration.cpp	96.13%	4 Missing and 4 partials ⚠️
src/util/DateYearDuration.h	97.36%	0 Missing and 1 partial ⚠️
src/util/Duration.h	98.38%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
+ Coverage   89.06%   89.12%   +0.06%     
==========================================
  Files         328      332       +4     
  Lines       29294    29494     +200     
  Branches     3262     3291      +29     
==========================================
+ Hits        26090    26287     +197     
- Misses       2054     2056       +2     
- Partials     1150     1151       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joka921

A first round of reviews.
I think we should fully integrate the
xs:dayTimeDuration
into the IDs.

src/util/Date.h

src/engine/sparqlExpressions/DateExpressions.cpp

joka921

This already looks very mature.
I have made a thorough pass over everything, most things are small
(typos, documentation, readability).
Thank you very much.

src/util/DateYearDuration.cpp

src/util/Duration.h

test/DateYearDurationTest.cpp

joka921 · 2024-07-11T07:30:22Z

test/DateYearDurationTest.cpp

+}
+
+//______________________________________________________________________________
+DayTimeDuration::DurationValue toAndFromMilliseconds(int days, int hours,


What is the use case of this?

W.r.t. large duration values, which are mostly internally normalized by conversion to milliseconds, it is quite complicated to test directly over the xsd:dayTimeduration strings, because the (input) duration string is different compared to the input string in terms of values. Thus i decided (while coding the setValues() and getValues()) to test this procedure explicitely.

test/DateYearDurationTest.cpp

src/util/Duration.h

Co-authored-by: Johannes Kalmbach <[email protected]>

sonarqubecloud · 2024-07-15T13:21:46Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

realHannes and others added 30 commits April 25, 2024 19:07

Added conversion str to int

99da434

templated function for toNumeric, add declaration to NaryExpression.h

424d023

str to num for SparqlExpression implemented + added test

0117e82

Merge branch 'ad-freiburg:master' into master

35fd0b1

Update src/engine/sparqlExpressions/StringExpressions.cpp

94356c2

Co-authored-by: Johannes Kalmbach <[email protected]>

Update src/engine/sparqlExpressions/StringExpressions.cpp

decc8ba

Co-authored-by: Johannes Kalmbach <[email protected]>

Update src/engine/sparqlExpressions/StringExpressions.cpp

850152c

Co-authored-by: Johannes Kalmbach <[email protected]>

Update src/engine/sparqlExpressions/StringExpressions.cpp

d650d67

Co-authored-by: Johannes Kalmbach <[email protected]>

using now absl::from_chars() and stripping whitespaces for string to …

46cc697

…number conv.

added new functions to processIriFuntionCall() (for string to number)

7fc5c28

renaming to: toIntExpression and toDoubleExpression for later more ge…

efb0e24

…neral implementation

made format (clang-format-16)

a88537c

Update src/parser/sparqlParser/SparqlQleverVisitor.cpp

ca1e2e0

Co-authored-by: Johannes Kalmbach <[email protected]>

Update src/parser/sparqlParser/SparqlQleverVisitor.cpp

4adc831

Co-authored-by: Johannes Kalmbach <[email protected]>

renaming in NaryExpression.h for accordance with other function, addi…

d0f0d63

…ng correct prefix in Constants.h

added test coverage for function calls makeIntExpression and make Dou…

a118609

…bleExpression

toNumeric has now correct behavior and uses absl::from_chars() and st…

062052e

…d::from_chars()

made clang-format for NaryExpressionImpl.h

6d0f42a

Merge branch 'ad-freiburg:master' into master

f90b8e2

Merge branch 'ad-freiburg:master' into master

fb88493

Merge remote-tracking branch 'upstream/master'

b2eb514

Merge branch 'ad-freiburg:master' into master

b165ac1

Merge branch 'master' of https://github.com/realHannes/qlever

7a3dfb2

Merge branch 'ad-freiburg:master' into master

fc0ad3a

Merge branch 'ad-freiburg:master' into master

f3e6086

Merge branch 'ad-freiburg:master' into master

fd4c351

Merge branch 'ad-freiburg:master' into master

220c9bf

Merge branch 'ad-freiburg:master' into master

a81cb8a

Merge branch 'ad-freiburg:master' into master

acc0109

Merge branch 'ad-freiburg:master' into master

cb8e560

realHannes and others added 3 commits June 28, 2024 10:00

Merge branch 'ad-freiburg:master' into master

2b39970

Merge branch 'ad-freiburg:master' into master

a0101e4

implemented expression timezone() + anility to compare w.r.t. timezone

2d3861b

joka921 requested changes Jul 1, 2024

View reviewed changes

src/util/Date.h Outdated Show resolved Hide resolved

src/util/Date.h Outdated Show resolved Hide resolved

src/util/Date.h Outdated Show resolved Hide resolved

src/engine/sparqlExpressions/DateExpressions.cpp Show resolved Hide resolved

realHannes and others added 9 commits July 8, 2024 13:10

added class for DayTimeDuration (xsd:dayTimeDuration)

8432c20

Merge branch 'master' into add_timezone_expression

ed7fad5

fix merge conflict

f951979

remove std::move

f876cde

one more build fix

a5e5909

improve / fix tests

b0b054e

small change to test

1b5ec54

use absl::StrFormat + changes for sonarcloud

b52a517

throw DurationOverFlowException in correct namespace

9302a8d

joka921 requested changes Jul 11, 2024

View reviewed changes

realHannes added 2 commits July 12, 2024 16:01

applied proposed changes

bf3a24f

use initialization list

caa9b4d

joka921 reviewed Jul 14, 2024

View reviewed changes

src/util/Duration.h Outdated Show resolved Hide resolved

src/util/Duration.h Outdated Show resolved Hide resolved

realHannes and others added 2 commits July 15, 2024 14:00

update src/util/Duration.h

0fdd658

Co-authored-by: Johannes Kalmbach <[email protected]>

update src/util/Duration.h

52fecaa

Co-authored-by: Johannes Kalmbach <[email protected]>

joka921 approved these changes Jul 15, 2024

View reviewed changes

joka921 changed the title ~~implemented expression timezone()~~ Implement function timezone() Jul 15, 2024

joka921 merged commit 67145fa into ad-freiburg:master Jul 15, 2024
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement function `timezone()` #1386

Implement function `timezone()` #1386

realHannes commented Jun 30, 2024 •

edited by joka921

Loading

codecov bot commented Jun 30, 2024 •

edited

Loading

joka921 left a comment

joka921 left a comment

joka921 Jul 11, 2024

realHannes Jul 12, 2024

sonarqubecloud bot commented Jul 15, 2024

Implement function timezone() #1386

Implement function timezone() #1386

Conversation

realHannes commented Jun 30, 2024 • edited by joka921 Loading

codecov bot commented Jun 30, 2024 • edited Loading

Codecov Report

joka921 left a comment

Choose a reason for hiding this comment

joka921 left a comment

Choose a reason for hiding this comment

joka921 Jul 11, 2024

Choose a reason for hiding this comment

realHannes Jul 12, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 15, 2024

Quality Gate passed

Implement function `timezone()` #1386

Implement function `timezone()` #1386

realHannes commented Jun 30, 2024 •

edited by joka921

Loading

codecov bot commented Jun 30, 2024 •

edited

Loading